[v17] Adjust levels of Vale rules #49661
Open
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Dec 2, 2024
|
🤖 Vercel preview here: https://docs-djejmanvg-goteleport.vercel.app/docs |
|
@mmcallister Following up on this one if you have time. Thanks! |
mmcallister
approved these changes
Dec 4, 2024
ptgott
added
the
no-changelog
Backports #48850 Change the error levels of Vale style rules to pave the way for requiring the Vale linter. Use the `warning` level for all rules except for the step numbering rule. This mostly preserves the existing "check prose style" GitHub Actions job behavior, in which Vale style rules are optional. The one rule we require is to ensure that numbered `Step n/d` headings follow the correct numbering scheme.
ptgott
force-pushed
the
paul.gottschling/48850-bp-v17
branch
from
3290419
to
c5a8800
Compare
|
🤖 Vercel preview here: https://docs-jf25mpuep-goteleport.vercel.app/docs |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #48850
Change the error levels of Vale style rules to pave the way for requiring the Vale linter. Use the
warninglevel for all rules except for the step numbering rule. This mostly preserves the existing "check prose style" GitHub Actions job behavior, in which Vale style rules are optional. The one rule we require is to ensure that numberedStep n/dheadings follow the correct numbering scheme.